Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with importing auth0_organization_connection #301

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Aug 26, 2022

🔧 Changes

Raised in #299, it appears that we were not able to import correctly the org_conn resource due to the fact that importing doesn't have access to the underlying terraform config, so we can't reuse the org ID and conn ID from there, we need to parse it from the ID and then pass it to the read func so it can find a value when doing data.Get().

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Aug 26, 2022
@sergiught sergiught marked this pull request as ready for review August 26, 2022 07:37
@sergiught sergiught requested a review from a team as a code owner August 26, 2022 07:37
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Much like #302, I think establishing this convention in the codebase will improve the import process overall.

@sergiught sergiught merged commit 8112a02 into main Aug 26, 2022
@sergiught sergiught deleted the patch/issue#299-org-conn-fix branch August 26, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants