Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data source client to search by name through all available clients #306

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Aug 26, 2022

🔧 Changes

It was pointed out in #267 that the current client data source stops searching based on client name after the first 50 items on the first page of the list. We're fixing that by looping through all the available pages until we find the correct client based on name. Same kind of mechanism already present here: https://github.com/auth0/go-auth0/blob/7fd1c745ba270864d3f4ac5c3284fa52f7fdf8e0/management/client_grant.go#L46

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Aug 26, 2022
@sergiught sergiught force-pushed the patch/issue#267-data-source-per-page-search branch from f69fb28 to d4d9758 Compare August 26, 2022 16:52
@sergiught sergiught marked this pull request as ready for review August 26, 2022 16:56
@sergiught sergiught requested a review from a team as a code owner August 26, 2022 16:56
@sergiught sergiught merged commit 393ae76 into main Aug 27, 2022
@sergiught sergiught deleted the patch/issue#267-data-source-per-page-search branch August 27, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants