Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-242: Documenting connections options for all strategies via examples #383

Merged
merged 30 commits into from
Oct 27, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Oct 26, 2022

🔧 Changes

This PR introduces more coverage of connection options documentation. This comprehensive coverage now includes examples for all connection strategies and each example includes all configurable options. This work was done in response to reported confusion regarding connections documentation, see: #365.

Because of the way that that the documentation was generated, this was the easiest way to document and demonstrate the usage of all connection strategies. More ideal approaches were discussed but were deemed too manual and susceptible to drift. So for now, this will serve as a first pass with the possibility of more improvements over time if necessary.

📚 References

Relevant issue: #365

🔬 Testing

Manually tested by applying examples against a live tenant.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner October 26, 2022 21:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 86.91% // Head: 86.74% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (f79ed41) compared to base (582190b).
Patch has no changes to coverable lines.

❗ Current head f79ed41 differs from pull request most recent head afd14d0. Consider uploading reports for the commit afd14d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   86.91%   86.74%   -0.18%     
==========================================
  Files          40       41       +1     
  Lines        8593     8730     +137     
==========================================
+ Hits         7469     7573     +104     
- Misses        863      890      +27     
- Partials      261      267       +6     
Impacted Files Coverage Δ
...ernal/provider/resource_auth0_connection_client.go 75.36% <0.00%> (ø)
internal/provider/provider.go 59.59% <0.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willvedd willvedd merged commit eeffc4b into main Oct 27, 2022
@willvedd willvedd deleted the DXCDT-242-connection-doc-examples-improvements branch October 27, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants