-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for breached_password_detection.stage
on auth0_attack_protection
resource
#445
Add support for breached_password_detection.stage
on auth0_attack_protection
resource
#445
Conversation
@nialdaly You're a rockstar ⭐ Much appreciated for already trying to contribute this to the repo. Please don't hesitate to ask for support if needed to get this in the right place. Adding tests and making them pass for terraform will be very similar to how they are done on the Go SDK side: https://github.com/auth0/go-auth0/blob/main/CONTRIBUTING.md (I have on my TODO to update it here as well). Also make sure to update the examples and to regenerate the docs afterwards with |
Hey @sergiught thanks for the pointers! I've updated the test recordings, not 100% sure if they are correct. |
When running the tests locally @sergiught I'm getting the following error. I'm not sure if its related to the updated test recording:
|
test/data/recordings/TestAccAttackProtectionBreachedPasswordDetection.yaml
Outdated
Show resolved
Hide resolved
test/data/recordings/TestAccAttackProtectionBreachedPasswordDetection.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @nialdaly 💪🏻 Fantastic contribution!
breached_password_detection.stage
supportbreached_password_detection.stage
on auth0_attack_protection
resource
Thanks for all your help! @sergiught |
Summary
This PR aims to close this issue.