Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-363: Add connection data source #470

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Feb 8, 2023

🔧 Changes

Adding support for connection data sources in this PR. They'll be available by quering based on connection_id or name. However it was necessary to include the enabled_clients as a read only value on the connection resource as we're reusing the same logic as the resource. Historically we removed it when we added the auth0_connection_client association to prevent race conditions, but removing it is unnecessary if the value is read only on the resource.

To note that the description of nested schemas on the connection data source is missing due to faulty behavior on the resource to data source transformation. This will be tackled in a follow up PR: #471.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Feb 8, 2023
@sergiught sergiught marked this pull request as ready for review February 8, 2023 13:06
@sergiught sergiught requested a review from a team as a code owner February 8, 2023 13:06
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I agree with the decision to re-introduce enabled_clients as a read-only field for convenience 👍

@sergiught sergiught merged commit 5bb7908 into main Feb 8, 2023
@sergiught sergiught deleted the feature/DXCDT-363-connection-data-source branch February 8, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants