Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#406: Simplify management of branding themes #504

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR aims at simplifying and improving the management of branding themes following the discussion in #406. As we can only ever have 1 branding theme at the moment, we can check if a default one is set and reuse that ID when creating the theme, triggering an update instead. The read is also changed to check for the default theme instead.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the issue#406-branding-theme-singleton branch from 55ec6ed to e5e7363 Compare February 22, 2023 10:11
@sergiught sergiught force-pushed the issue#406-branding-theme-singleton branch from e5e7363 to 7d354a3 Compare February 22, 2023 10:14
@sergiught sergiught marked this pull request as ready for review February 22, 2023 10:18
@sergiught sergiught requested a review from a team as a code owner February 22, 2023 10:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 85.35% // Head: 85.31% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7d354a3) compared to base (c1817e8).
Patch coverage: 41.66% of modified lines in pull request are covered.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           patch/DXCDT-381-speedy-tests     #504      +/-   ##
================================================================
- Coverage                         85.35%   85.31%   -0.05%     
================================================================
  Files                                76       76              
  Lines                              9899     9892       -7     
================================================================
- Hits                               8449     8439      -10     
- Misses                             1147     1149       +2     
- Partials                            303      304       +1     
Impacted Files Coverage Δ
internal/auth0/branding/resource_theme.go 96.41% <30.00%> (-0.45%) ⬇️
internal/auth0/branding/data_source_theme.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from patch/DXCDT-381-speedy-tests to main February 22, 2023 14:07
@sergiught sergiught merged commit 3e8b311 into main Feb 22, 2023
@sergiught sergiught deleted the issue#406-branding-theme-singleton branch February 22, 2023 14:08
@kaiwen-wang
Copy link

How do you get the branding theme id using the web dashboard?

@sergiught
Copy link
Contributor Author

Hey @kaiwen-wang 👋🏻

You can use any UUID4 as we've improved the DX for managing branding themes considering we can only ever have one, it's unnecessary to retrieve the exact ID.

You can use for example: terraform import auth0_branding_theme.<your-resource-name> <anyUUID: d2ba3db0-7a6d-4da1-9a97-08ab9188f645>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants