-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue#406: Simplify management of branding themes #504
Conversation
55ec6ed
to
e5e7363
Compare
e5e7363
to
7d354a3
Compare
Codecov ReportBase: 85.35% // Head: 85.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## patch/DXCDT-381-speedy-tests #504 +/- ##
================================================================
- Coverage 85.35% 85.31% -0.05%
================================================================
Files 76 76
Lines 9899 9892 -7
================================================================
- Hits 8449 8439 -10
- Misses 1147 1149 +2
- Partials 303 304 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
How do you get the branding theme id using the web dashboard? |
Hey @kaiwen-wang 👋🏻 You can use any UUID4 as we've improved the DX for managing branding themes considering we can only ever have one, it's unnecessary to retrieve the exact ID. You can use for example: |
🔧 Changes
This PR aims at simplifying and improving the management of branding themes following the discussion in #406. As we can only ever have 1 branding theme at the moment, we can check if a default one is set and reuse that ID when creating the theme, triggering an update instead. The read is also changed to check for the default theme instead.
📚 References
🔬 Testing
📝 Checklist