Don't override imported connection_client id #562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR changes the
importConnectionClient
function which handles the importing ofauth0_connection_client
resources. When repeatedly importing this resource (like is possible when using a tool like Pulumi) the imported connection client has a new id every time even though it has not changed. This causes the IaC tool to want to recreate the resource, which breaks your environment. Using just the combination ofconnection_id:client_id
is unique enough and should be fine to use the identifier for this resource, since I don't think there is a situation where duplicates would exist. (and if they do, that sounds like a misconfiguration)The only change is that the internal id is now the same each time the same resource is imported.
🔬 Testing
This can be tested by importing connection clients!
📝 Checklist
I have added documentation for all new/changed functionality (or N/A)