DXCDT-443: OIDC Back-channel logout #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
changed the title
…om/auth0/terraform-provider-auth0 into DXCDT-443-oidc-back-channel-logout
sergiught
force-pushed
the
DXCDT-443-oidc-back-channel-logout
branch
from
14a29c0 to
ee79819
Compare
sergiught
reviewed
May 15, 2023
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, | ||
| Optional: true, |
There was a problem hiding this comment.
We could consider adding a validation here to ensure we only pass 1 URL and error early, considering the API only accepts one url at the moment.
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 87.42% 87.44% +0.02%
==========================================
Files 68 68
Lines 10391 10412 +21
==========================================
+ Hits 9084 9105 +21
Misses 988 988
Partials 319 319
|
…om/auth0/terraform-provider-auth0 into DXCDT-443-oidc-back-channel-logout
sergiught
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adding support for managing a tenant's OIDC back-channel logout urls. This feature requires a feature flag to be enabled on the tenant, when disabled, the API will return a
Additional properties not allowed: oidc_backchannel_logout400 error. For this reason, the test recordings were done against a tenant that had the feature flag enabled, but will not succeed when run against a live tenant without the feature flag enabled.Note: Remaining as draft until Go Auth0 cuts a release with the depending support.
📚 References
🔬 Testing
Added assertions for empty value, adding a url and removing a url.
📝 Checklist