DXCDT-431: auth0_role_permission resource
#582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
commented
May 16, 2023
| # relationship between the user and its roles. | ||
| resource auth0_user_roles user_roles { | ||
| user_id = auth0_user.user.id | ||
| roles = [auth0_role.admin.id] | ||
| } | ||
|
|
||
| # Or the auth0_user_roles to manage a 1:1 |
…om/auth0/terraform-provider-auth0 into DXCDT-431-role-permission-resource
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 87.44% 87.26% -0.19%
==========================================
Files 68 69 +1
Lines 10412 10547 +135
==========================================
+ Hits 9105 9204 +99
- Misses 988 1021 +33
- Partials 319 322 +3
|
2 tasks
sergiught
reviewed
May 17, 2023
sergiught
reviewed
May 17, 2023
| Config: acctest.ParseTestName(testAccRolePermissionsOneAssigned, strings.ToLower(t.Name())), | ||
| }, | ||
| { | ||
| RefreshState: true, |
There was a problem hiding this comment.
Suggested change
| RefreshState: true, | |
| RefreshState: true, |
Should this be here? I think we can move the checks in the config above if we use the data source as the last elements that gets refreshed.
There was a problem hiding this comment.
This needs to be here for tests to pass. The data source gets executed after (or at best, during) the deletions of the auth0_role_permission resources. AFAICT, there is no way to depend on a deleted resource.
There was a problem hiding this comment.
Ah, I see that now 👍🏻 , indeed the execution flow on a terraform apply is:
read and refresh state
creations
updates
deletions
so we need another refresh state after the deletion.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Introducing the
auth0_role_permissionresource which enables management of role permissions through a 1-1 relationship.This PR shares similarities with the
auth0_user_permissionresource (#574) but with extra considerations for the already-existingpermissionsfield on the role resource like the migration guide and deprecation.📚 References
Similar PR: #574
🔬 Testing
Added full suite of integration tests for this resource.
📝 Checklist