GH-593: Fix import issue on auth0_connection_clients #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 86.86% 86.86%
=======================================
Files 71 71
Lines 11148 11149 +1
=======================================
+ Hits 9684 9685 +1
Misses 1116 1116
Partials 348 348
|
This was referenced May 23, 2023
willvedd
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As raised in #593 after importing an auth0_connection_clients the resource tries to recreate itself, due to a missing
data.Set(connection_id, connection.GetID()). This PR fixes that and adds a test case for such cases.📚 References
🔬 Testing
📝 Checklist