DXCDT-470: Updating ordering of value.difference, updating tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
DXCDT-470-value.difference-order-operations
branch
from
e8a1954 to
b229663
Compare
sergiught
approved these changes
Jun 22, 2023
sergiught
pushed a commit
that referenced
this pull request
Jun 25, 2023
Co-authored-by: Will Vedder <will.vedder@okta.com>
sergiught
pushed a commit
that referenced
this pull request
Jun 25, 2023
Co-authored-by: Will Vedder <will.vedder@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Necessary reordering the add and remove operations returned form
value.Difference(). It is necessary in cases where non-primitive values are process to remove entities before adding them. The changes here are largely to maintain consistency across the codebase and ensure correct operation.This change was sparked by a related change in this PR: https://github.com/auth0/terraform-provider-auth0/pull/632/files#diff-8fd4b238e4ecbadc212d2f60d719e9c3666cf53523acecf785f03284f47132bbR83.
🔬 Testing
Added acceptance test assertions.
📝 Checklist