Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/X] DXCDT-441: Reintroduce support for rms client addon #658

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for rms client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v1@b73d86a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             v1     #658   +/-   ##
=====================================
  Coverage      ?   86.85%           
=====================================
  Files         ?       80           
  Lines         ?    12048           
  Branches      ?        0           
=====================================
  Hits          ?    10464           
  Misses        ?     1211           
  Partials      ?      373           

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-sb-3 branch from 731ef19 to acf42da Compare June 26, 2023 18:24
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-rms-4 branch from ab6f241 to 4306883 Compare June 26, 2023 18:25
@sergiught sergiught marked this pull request as ready for review June 26, 2023 18:25
@sergiught sergiught requested a review from a team as a code owner June 26, 2023 18:25
@sergiught sergiught requested a review from Widcket June 26, 2023 18:25
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-sb-3 branch from acf42da to 5b6d6e8 Compare June 27, 2023 15:04
Base automatically changed from feature/DXCDT-441-client-addons-azure-sb-3 to v1 June 27, 2023 15:18
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-rms-4 branch from 4306883 to 418397e Compare June 27, 2023 15:20
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-rms-4 branch from 418397e to 9befe4a Compare June 27, 2023 15:21
@sergiught sergiught merged commit 89ec1c7 into v1 Jun 27, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-rms-4 branch June 27, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants