Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10/X] DXCDT-441: Reintroduce support for firebase client addon #666

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for firebase client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner June 28, 2023 08:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #666 (53136ce) into feature/DXCDT-441-client-addons-egnyte-9 (760bb72) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                              @@
##           feature/DXCDT-441-client-addons-egnyte-9     #666      +/-   ##
============================================================================
+ Coverage                                     87.06%   87.14%   +0.07%     
============================================================================
  Files                                            80       80              
  Lines                                         12248    12318      +70     
============================================================================
+ Hits                                          10664    10734      +70     
  Misses                                         1211     1211              
  Partials                                        373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 92.24% <100.00%> (+0.37%) ⬆️
internal/auth0/client/flatten.go 96.70% <100.00%> (+0.23%) ⬆️
internal/auth0/client/resource.go 97.40% <100.00%> (+0.12%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-egnyte-9 branch from 8389d00 to 760bb72 Compare June 29, 2023 07:44
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-firebase-10 branch from 436c169 to b858301 Compare June 29, 2023 07:46
@sergiught sergiught requested a review from Widcket June 29, 2023 07:46
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-firebase-10 branch from b858301 to 53136ce Compare June 29, 2023 07:51
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-egnyte-9 branch from 760bb72 to 1ccc0d6 Compare June 29, 2023 14:22
Base automatically changed from feature/DXCDT-441-client-addons-egnyte-9 to v1 June 29, 2023 14:31
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-firebase-10 branch from 53136ce to 7fc1a11 Compare June 29, 2023 14:32
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-firebase-10 branch from 7fc1a11 to 0c54cfd Compare June 29, 2023 14:34
@sergiught sergiught merged commit fb04afc into v1 Jun 29, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-firebase-10 branch June 29, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants