DXCDT-483: Skip is_token_endpoint_ip_header_trusted on client create
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 86.57% 86.59% +0.01%
==========================================
Files 83 83
Lines 12414 12416 +2
==========================================
+ Hits 10748 10752 +4
+ Misses 1267 1265 -2
Partials 399 399
|
Widcket
reviewed
Jul 10, 2023
willvedd
reviewed
Jul 10, 2023
willvedd
approved these changes
Jul 10, 2023
sergiught
force-pushed
the
patch/DXCDT-483-skip
branch
from
0609c84 to
32e54f4
Compare
sergiught
force-pushed
the
patch/DXCDT-483-skip
branch
from
32e54f4 to
b7ec78f
Compare
iwahbe
added a commit
to pulumi/pulumi-auth0
that referenced
this pull request
Jul 12, 2023
This reflects auth0/terraform-provider-auth0#696, which prevents effectively setting this property on create.
iwahbe
added a commit
to pulumi/pulumi-auth0
that referenced
this pull request
Jul 12, 2023
* make tfgen * make build_sdks * Fix lints * Don't set `isTokenEndpointIpHeaderTrusted` on create This reflects auth0/terraform-provider-auth0#696, which prevents effectively setting this property on create. --------- Co-authored-by: pulumi-bot <runner@fv-az246-187.5psvvmmilinuxk0dtff2z2cd4h.cx.internal.cloudapp.net> Co-authored-by: Ian Wahbe <ian@wahbe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As mentioned in #620, directly creating a client with
is_token_endpoint_ip_header_trustedset to true, without setting the authentication method toclient_secret_*will result in an error. To circumvent this we'll only allow this setting to get updated after the creation of the client.📚 References
🔬 Testing
📝 Checklist