Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiring 'default_redirection_uri' parameter in 'auth0_tenant' into Auth0 API call #71

Merged

Conversation

danielgrant
Copy link
Contributor

@danielgrant danielgrant commented Feb 28, 2022

Description

The auth0_tenant resource has supported the default_redirection_uri for some time (see commit a8d7db4). However, whilst this commit added the parameter, tests, and documentation, it didn't actually wire the parameter into the underlying Auth0 API calls (i.e. it's absent from readTenant and buildTenant in resource_auth0_tenant.go) and thus setting this parameter doesn't actually do anything.

This PR adds default_redirection_uri into readTenant and buildTenant and maps it to the DefaultRedirectionURI field of management.Tenant.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@danielgrant danielgrant requested a review from a team as a code owner February 28, 2022 09:14
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @danielgrant ! Great work in spotting this.

@sergiught sergiught merged commit 1c60a83 into auth0:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants