Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Shopify-Spotify connection options mixup #728

Merged
merged 8 commits into from
Jul 17, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 17, 2023

🔧 Changes

In #694 , I accidentally removed a reference to the Shopify connection options enum instead of the Spotify enum. This PR fixes this mixup. This change was released in v0.50.0 last week.

📚 References

Related PR: #694

🔬 Testing

N/A.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner July 17, 2023 15:01
@sergiught sergiught changed the base branch from main to v1 July 17, 2023 15:21
@codecov-commenter
Copy link

Codecov Report

Merging #728 (f272df2) into v1 (3525cea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #728   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files          87       87           
  Lines       13235    13235           
=======================================
  Hits        11580    11580           
  Misses       1251     1251           
  Partials      404      404           
Impacted Files Coverage Δ
internal/auth0/connection/expand.go 96.31% <ø> (ø)

@willvedd willvedd merged commit b3f3f95 into v1 Jul 17, 2023
@willvedd willvedd deleted the fix-spotify-shopify-connection-removal branch July 17, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants