Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-475: Prevent sending empty payloads for client addons #759

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This fixes an issue where we would send an empty payload for all the client addons, even if modifying or adding just one type.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review July 27, 2023 12:09
@sergiught sergiught requested a review from a team as a code owner July 27, 2023 12:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #759 (ac56355) into v1 (48b575c) will increase coverage by 0.60%.
The diff coverage is 96.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #759      +/-   ##
==========================================
+ Coverage   89.80%   90.41%   +0.60%     
==========================================
  Files          99       99              
  Lines       13077    13119      +42     
==========================================
+ Hits        11744    11861     +117     
+ Misses        941      891      -50     
+ Partials      392      367      -25     
Files Changed Coverage Δ
internal/auth0/client/resource.go 98.84% <62.50%> (-0.25%) ⬇️
internal/auth0/client/expand.go 91.75% <100.00%> (+3.58%) ⬆️
internal/auth0/client/flatten.go 98.69% <100.00%> (+13.23%) ⬆️

@sergiught sergiught force-pushed the patch/GH-475-fix-client-addons branch from 09d7497 to ac56355 Compare July 28, 2023 15:01
@sergiught sergiught merged commit f9a68b9 into v1 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants