-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-518: Stop requiring read:client_keys
permission for reading the auth0_client_credentials
resource
#795
Conversation
data.Id(), | ||
management.IncludeFields( | ||
"client_id", | ||
"client_secret", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By explicitly requiring the client_secret
to be within the response, we were implying a requirement on the read:client_keys
permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♂️
89e50ac
to
bbc0dd9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #795 +/- ##
==========================================
+ Coverage 90.50% 90.54% +0.03%
==========================================
Files 99 99
Lines 13265 13256 -9
==========================================
- Hits 12005 12002 -3
+ Misses 893 889 -4
+ Partials 367 365 -2
|
bbc0dd9
to
f4fe114
Compare
f4fe114
to
4bc3172
Compare
🔧 Changes
This PR stops requiring the
read:client_keys
permission for reading theauth0_client_credentials
resource by removing the include fields query param for client_secret. This will be set to a specific value if the permissions is available, otherwise it will be an empty string.📚 References
auth0_client_credentials
requiresread:client_secret
permissions #774🔬 Testing
Tested manually, as our automated tests rely on the full set of permissions to run.
📝 Checklist