Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-872: Add auth method defaults on client creation #878

Merged
merged 1 commit into from
Nov 9, 2023
Merged

GH-872: Add auth method defaults on client creation #878

merged 1 commit into from
Nov 9, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Adding defaults to the TokenEndpointAuthMethod when a client gets created. These defaults are set based on the app type.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner November 9, 2023 16:03
willvedd
willvedd approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@sergiught sergiught merged commit 3f67c52 into main Nov 9, 2023
4 checks passed
@sergiught sergiught deleted the GH-872-client-auth-method-default branch November 9, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @willvedd