Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible PKCE values in OIDC #896

Merged

Conversation

tomasz-torcz-airspace-intelligence
Copy link
Contributor

🔧 Changes

Auth0 accepts S256 for OIDC pkce, not s256

📚 References

#895

📝 Checklist

  • [N/A] All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@m3talsmith
Copy link
Contributor

@tomasz-torcz-airspace-intelligence this is looking good. It appears to be missing the documentation generation for the changes and it would be nice to see some testing around it; but documentation changes at a minimum: make docs.

@tomasz-torcz-airspace-intelligence
Copy link
Contributor Author

Hey, I've regenerated the docs.
Unfortunately, I'm not skilled enough to add tests for that.

@codecov-commenter
Copy link

Codecov Report

Merging #896 (c9e126e) into main (d50bfd3) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   90.03%   89.99%   -0.05%     
==========================================
  Files         101      101              
  Lines       13779    13779              
==========================================
- Hits        12406    12400       -6     
- Misses        973      977       +4     
- Partials      400      402       +2     

see 1 file with indirect coverage changes

@sergiught
Copy link
Contributor

Thanks for the contribution @tomasz-torcz-airspace-intelligence !

@sergiught sergiught merged commit 752adfe into auth0:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants