-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong title and icon for login widget #385
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -230,8 +230,7 @@ public function get_lock_options() { | |
$extraOptions["callbackURL"] = $this->get_code_callback_url(); | ||
} | ||
|
||
$options_obj = array_merge( $extraOptions, $options_obj ); | ||
$options_obj = array_merge( $options_obj , $extended_settings ); | ||
$options_obj = array_merge( $extraOptions, $options_obj, $extended_settings ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the previous snippet you change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cocojoe - Array dimensions, recursive vs. not recursive. |
||
|
||
if ( ! $this->show_as_modal() ) { | ||
$options_obj['container'] = 'auth0-login-form'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what is the logic here for duplicate entries.
extraOptions
are over ridden byoptions_obj
but this can then be over ridden byextended_settings
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cocojoe - Correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the naming seems odd. However, it is the same order as the original so fair enough