Fix install and DB update errors #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
May 24, 2018
| @@ -180,11 +150,11 @@ public function install_db( $version_to_install = null, $app_token = '' ) { | |||
| // Update Lock and Auth versions | |||
|
|
|||
| if ( '//cdn.auth0.com/js/lock/11.0.0/lock.min.js' === $options->get( 'cdn_url' ) ) { | |||
There was a problem hiding this comment.
why is this hardcoded to 11.0.0 and later a different value is assigned? same for the one below
There was a problem hiding this comment.
The logic is difficult to follow, I know, but they are, technically, doing different things.
| @@ -180,11 +150,11 @@ public function install_db( $version_to_install = null, $app_token = '' ) { | |||
| // Update Lock and Auth versions | |||
|
|
|||
| if ( '//cdn.auth0.com/js/lock/11.0.0/lock.min.js' === $options->get( 'cdn_url' ) ) { | |||
| $options->set( 'cdn_url', '//cdn.auth0.com/js/lock/11.1/lock.min.js' ); | |||
| $options->set( 'cdn_url', WPA0_LOCK_CDN_URL ); | |||
There was a problem hiding this comment.
this is already set under this next line (snippet)
if ( $this->current_db_version < 15 || 15 === $version_to_install ) {
There was a problem hiding this comment.
Not exactly. Logic is difficult to follow but this serves a different function.
lbalmaceda
approved these changes
May 24, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_lock_10setting in DB update process and defaults