%s.
', $text );
}
+ /**
+ * Check if the setting is provided by a constant and indicate.
+ *
+ * @param string $input_name - Input name for the field, used as option key.
+ */
+ protected function render_const_notice( $input_name ) {
+ printf(
+ '%s %s
diff --git a/tests/bootstrap.php b/tests/bootstrap.php
index a1b0e3c4..ef64e500 100644
--- a/tests/bootstrap.php
+++ b/tests/bootstrap.php
@@ -2,7 +2,7 @@
/**
* PHPUnit bootstrap file
*
- * @package Auth0
+ * @package WP-Auth0
*/
$_tests_dir = getenv( 'WP_TESTS_DIR' );
@@ -31,10 +31,10 @@ function _manually_load_plugin() {
require $_tests_dir . '/includes/bootstrap.php';
spl_autoload_register(
- function( $className ) {
- $fileName = stream_resolve_include_path( 'traits/' . $className . '.php' );
- if ( false !== $fileName ) {
- include $fileName;
+ function( $class_name ) {
+ $file_name = stream_resolve_include_path( 'traits/' . $class_name . '.php' );
+ if ( false !== $file_name ) {
+ include $file_name;
}
}
);
diff --git a/tests/testConstantSettings.php b/tests/testConstantSettings.php
new file mode 100644
index 00000000..ca4a3714
--- /dev/null
+++ b/tests/testConstantSettings.php
@@ -0,0 +1,193 @@
+get_all_constant_keys();
+ $this->assertCount( 3, $constant_keys );
+ $this->assertContains( 'domain', $constant_keys );
+ $this->assertContains( 'client_id', $constant_keys );
+ $this->assertContains( 'client_secret', $constant_keys );
+ }
+
+ /**
+ * Test that setting a constant will store the constant key.
+ */
+ public function testConstantPrefixFilter() {
+ $opts = new WP_Auth0_Options();
+ $opt_name = 'domain';
+
+ $this->assertEquals( self::DEFAULT_CONSTANT_PREFIX . 'DOMAIN', $opts->get_constant_name( $opt_name ) );
+
+ add_filter(
+ 'wp_auth0_settings_constant_prefix', function( $prefix ) {
+ return '__TEST_PREFIX_' . $prefix;
+ }, 10, 2
+ );
+
+ $this->assertEquals(
+ '__TEST_PREFIX_' . self::DEFAULT_CONSTANT_PREFIX . 'DOMAIN',
+ $opts->get_constant_name( $opt_name )
+ );
+ }
+
+ /**
+ * Test that setting a constant will change it's value on output.
+ */
+ public function testThatConstantOverridesWork() {
+ $opts = new WP_Auth0_Options();
+ $expected_opts = [];
+ $option_keys = array_keys( $opts->get_options() );
+
+ // Connections contains a sub-array of connection settings, does not need to be overridden.
+ foreach ( $option_keys as $opt_name ) {
+ $expected_opts[ $opt_name ] = rand();
+ $constant_name = $opts->get_constant_name( $opt_name );
+ $this->assertNull( $opts->get_constant_val( $opt_name ) );
+ define( $constant_name, $expected_opts[ $opt_name ] );
+ $this->assertTrue( $opts->has_constant_val( $opt_name ) );
+ }
+
+ // Create a new instance of the class to reset constant-set options.
+ $opts = new WP_Auth0_Options();
+ foreach ( $option_keys as $opt_name ) {
+ $this->assertEquals( $expected_opts[ $opt_name ], $opts->get_constant_val( $opt_name ), 'Opt name: ' . $opt_name );
+ $this->assertEquals( $expected_opts[ $opt_name ], $opts->get( $opt_name ), 'Opt name: ' . $opt_name );
+ }
+ }
+
+ /**
+ * Test that options can be set in memory and in the DB.
+ */
+ public function testSet() {
+ $opt_name = 'domain';
+ $expected_val_1 = rand();
+ $expected_val_2 = rand();
+ $opts = new WP_Auth0_Options();
+
+ // Test that a basic set without DB update works.
+ $result = $opts->set( $opt_name, $expected_val_1, false );
+ $this->assertTrue( $result );
+ $this->assertEquals( $expected_val_1, $opts->get( $opt_name ) );
+ $db_options = get_option( $opts->get_options_name() );
+ $this->assertNotEquals( $expected_val_1, $db_options[ $opt_name ] );
+
+ // Test that a basic set with DB update works.
+ $result = $opts->set( $opt_name, $expected_val_2, true );
+ $this->assertTrue( $result );
+ $this->assertEquals( $expected_val_2, $opts->get( $opt_name ) );
+ $db_options = get_option( $opts->get_options_name() );
+ $this->assertEquals( $expected_val_2, $db_options[ $opt_name ] );
+ }
+
+ /**
+ * Test that options cannot be set when a constant is present.
+ */
+ public function testSetWithConstant() {
+ $opt_name = 'domain';
+ $expected_val = rand();
+ $opts = new WP_Auth0_Options();
+ $constant_name = $opts->get_constant_name( $opt_name );
+
+ // Set a constant and make sure it works.
+ $this->assertNull( $opts->get_constant_val( $opt_name ) );
+ define( $constant_name, $expected_val );
+ $this->assertEquals( $expected_val, $opts->get_constant_val( $opt_name ) );
+
+ // Try to set an option with the constant set.
+ $result = $opts->set( $opt_name, rand(), false );
+ $this->assertFalse( $result );
+ $this->assertNotEquals( $expected_val, $opts->get( $opt_name ) );
+ }
+
+ /**
+ * Test that commonly-overridden settings will show a notice.
+ */
+ public function testConstantSettingNoticeBasic() {
+ $opts = new WP_Auth0_Options();
+ $admin = new WP_Auth0_Admin_Basic( $opts );
+
+ $fields = [
+ [
+ 'opt_name' => 'domain',
+ 'label_for' => 'wpa0_domain',
+ 'render_function' => 'render_domain',
+ ],
+ [
+ 'opt_name' => 'client_id',
+ 'label_for' => 'wpa0_client_id',
+ 'render_function' => 'render_client_id',
+ ],
+ [
+ 'opt_name' => 'client_secret',
+ 'label_for' => 'wpa0_client_secret',
+ 'render_function' => 'render_client_secret',
+ ],
+ [
+ 'opt_name' => 'auth0_app_token',
+ 'label_for' => 'wpa0_auth0_app_token',
+ 'render_function' => 'render_auth0_app_token',
+ ],
+ ];
+
+ foreach ( $fields as $field ) {
+ $constant_name = self::DEFAULT_CONSTANT_PREFIX . strtoupper( $field['opt_name'] );
+ $override_val = self::FILTER_TEST_STRING . rand();
+ define( $constant_name, $override_val );
+
+ ob_start();
+ $admin->{$field['render_function']}( $field );
+ $field_html = ob_get_clean();
+
+ $input = $this->getDomListFromTagName( $field_html, 'input' );
+ $this->assertTrue( $input->item( 0 )->hasAttribute( 'disabled' ) );
+ $this->assertContains( self::CONSTANT_NOTICE_TEXT, $field_html );
+ $this->assertContains( $constant_name, $field_html );
+ }
+ }
+}
diff --git a/tests/testCustomDomains.php b/tests/testCustomDomains.php
index a2ee6869..f512054c 100644
--- a/tests/testCustomDomains.php
+++ b/tests/testCustomDomains.php
@@ -1,4 +1,11 @@
assertEquals( self::OPTIONS_NAME, $opts->get_options_name() );
// Make sure the number of options has not changed unintentionally.
- $this->assertEquals( 67, count( $opts->get_options() ) );
+ $this->assertEquals( self::DEFAULT_OPTIONS_COUNT, count( $opts->get_options() ) );
+ $this->assertEquals( self::DEFAULT_OPTIONS_COUNT, count( $opts->get_defaults() ) );
+
+ $opts_generic = new WP_Auth0_Options_Generic();
+ $this->assertEmpty( $opts_generic->get_defaults() );
}
/**
@@ -61,24 +74,78 @@ public function testThatFiltersOverrideValues() {
}
/**
- * Test that options can be set in memory and in the DB.
+ * Test that options can be set in memory without a DB update
+ */
+ public function testSetWithoutSave() {
+ $opt_name = 'domain';
+ $expected_val = rand();
+ $opts = new WP_Auth0_Options();
+
+ // Set the option and do not save.
+ $opts->set( $opt_name, $expected_val, false );
+ $this->assertEquals( $expected_val, $opts->get( $opt_name ) );
+
+ // Get the DB-saved options and make sure it was not saved.
+ $db_options = get_option( $opts->get_options_name() );
+ $this->assertNotEquals( $expected_val, $db_options[ $opt_name ] );
+ }
+
+ /**
+ * Test that options can be set and saved to the DB.
+ */
+ public function testSetWithSave() {
+ $opt_name = 'domain';
+ $expected_val = rand();
+ $opts = new WP_Auth0_Options();
+
+ // Set the option and flag to save (default).
+ $opts->set( $opt_name, $expected_val );
+ $this->assertEquals( $expected_val, $opts->get( $opt_name ) );
+
+ // Make sure the saved value is correct.
+ $db_options = get_option( $opts->get_options_name() );
+ $this->assertEquals( $expected_val, $db_options[ $opt_name ] );
+ }
+
+ /**
+ * Test that update_all works.
*/
- public function testSet() {
- $opt_name = 'domain';
- $expected_val_1 = rand();
- $expected_val_2 = rand();
- $opts = new WP_Auth0_Options();
-
- // Test that a basic set without DB update works.
- $opts->set( $opt_name, $expected_val_1, false );
- $this->assertEquals( $expected_val_1, $opts->get( $opt_name ) );
+ public function testUpdateAll() {
+ $opt_name = 'domain';
+ $expected_val = rand();
+ $opts = new WP_Auth0_Options();
+
+ // Set the option and flag to skip saving.
+ $opts->set( $opt_name, $expected_val, false );
+ $this->assertEquals( $expected_val, $opts->get( $opt_name ) );
+
+ // Get the database option to make sure it was not saved.
$db_options = get_option( $opts->get_options_name() );
- $this->assertNotEquals( $expected_val_1, $db_options[ $opt_name ] );
+ $this->assertNotEquals( $expected_val, $db_options[ $opt_name ] );
- // Test that a basic set with DB update works.
- $opts->set( $opt_name, $expected_val_2, true );
- $this->assertEquals( $expected_val_2, $opts->get( $opt_name ) );
+ // Explicitly save to the DB and make sure it's correct.
+ $opts->update_all();
$db_options = get_option( $opts->get_options_name() );
- $this->assertEquals( $expected_val_2, $db_options[ $opt_name ] );
+ $this->assertEquals( $expected_val, $db_options[ $opt_name ] );
+ }
+
+ /**
+ * Test that options can be saved for the first time.
+ */
+ public function testDeleteAndSave() {
+ $opts = new WP_Auth0_Options();
+
+ // Make sure we do not have options saved.
+ delete_option( $opts->get_options_name() );
+ $this->assertFalse( get_option( $opts->get_options_name() ) );
+
+ // Save and make sure it has been saved.
+ $opts->save();
+ $db_options = get_option( $opts->get_options_name() );
+ $this->assertCount( self::DEFAULT_OPTIONS_COUNT, $db_options );
+
+ // Now delete again and make sure it's gone.
+ $this->assertTrue( $opts->delete() );
+ $this->assertFalse( get_option( $opts->get_options_name() ) );
}
}
diff --git a/tests/traits/domDocumentHelpers.php b/tests/traits/domDocumentHelpers.php
index 5e139097..dfb5d38c 100644
--- a/tests/traits/domDocumentHelpers.php
+++ b/tests/traits/domDocumentHelpers.php
@@ -1,4 +1,10 @@