Add Management API framework #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
add-management-api-framework
branch
from
92983ab to
be1b8da
Compare
joshcanhelp
commented
Sep 18, 2018
| @@ -508,6 +508,7 @@ private function autoloader( $class ) { | |||
| $paths = array( | |||
| $source_dir, | |||
| $source_dir . 'admin/', | |||
| $source_dir . 'api/', | |||
There was a problem hiding this comment.
Add new directory to auto-load from.
joshcanhelp
commented
Sep 18, 2018
| ), | ||
| ); | ||
| return array( 'Auth0-Client' => base64_encode( wp_json_encode( $header_value ) ) ); | ||
| return WP_Auth0_Api_Abstract::get_info_headers(); |
There was a problem hiding this comment.
Returns an identical array.
joshcanhelp
commented
Sep 18, 2018
| * | ||
| * @param WP_Auth0_Api_Jobs_Verification $api_jobs_resend - WP_Auth0_Api_Jobs_Verification instance. | ||
| */ | ||
| public function __construct( WP_Auth0_Api_Jobs_Verification $api_jobs_resend ) { |
There was a problem hiding this comment.
Add dependency injection.
joshcanhelp
force-pushed
the
add-management-api-framework
branch
from
ea1cc17 to
3d649e5
Compare
joshcanhelp
force-pushed
the
add-management-api-framework
branch
from
3d649e5 to
e253e5f
Compare
joshcanhelp
force-pushed
the
add-management-api-framework
branch
from
13c0f3b to
41a16f1
Compare
joshcanhelp
commented
Sep 25, 2018
| @@ -120,6 +120,14 @@ public static function ro( $domain, $client_id, $username, $password, $connectio | |||
|
|
|||
There was a problem hiding this comment.
Most of the changes in this file are doc blocks to add TODOs for deprecation.
cocojoe
approved these changes
Sep 26, 2018
|
|
||
| /** | ||
| * Class WP_Auth0_Email_Verification | ||
| * Class WP_Auth0_Email_Verification. |
There was a problem hiding this comment.
In general some of these comments seem a little superfluous.
joshcanhelp
force-pushed
the
add-management-api-framework
branch
from
41a16f1 to
fc5c23c
Compare
joshcanhelp
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a more clear, complete, and easy-to-use access to the Management API, including better error logging when things go wrong.
WP_Auth0_Api_Abstractabstract class to provide a wrapper around the WP HTTP class. This can be extended to add Management API endpoints more easily with built-in error handling.WP_Auth0_Api_Client_Credentialsto perform a Client Credentials grant for API callsWP_Auth0_Api_Jobs_Verificationto perform re-send email functionality (mainly to show how the framework is used).WP_Auth0_Email_Verificationto use the new API framework, provide better error responses.WP_Auth0_Api_Clientas TODO for deprecation.Note to reviewers
This is a large PR but almost 60% of code added is related to testing.