Deprecate unused login methods and props #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
deprecate-login-manager-methods-and-props
branch
from
cd5e5c5 to
69e1f7c
Compare
lbalmaceda
reviewed
Oct 5, 2018
| @@ -774,6 +772,28 @@ protected function die_on_login( $msg = '', $code = 0, $login_link = true ) { | |||
| ); | |||
| } | |||
|
|
|||
| /* | |||
| * | |||
| * DEPRECATED | |||
There was a problem hiding this comment.
why this flying on its own away from a valid method?
There was a problem hiding this comment.
It's not, just a section indicator, everything below is deprecated
lbalmaceda
reviewed
Oct 5, 2018
| public function redirect_to_help() { | ||
|
|
||
| } | ||
| public function redirect_to_help() {} |
There was a problem hiding this comment.
is it worthy to add the deprecated docblock here as well?
There was a problem hiding this comment.
I'm not entirely sure what to do with it yet. Serves no purpose but is used in a hook above. Will address when this class gets a once-over 👍
joshcanhelp
changed the title
lbalmaceda
reviewed
Oct 5, 2018
lib/WP_Auth0_Users.php
Outdated
| * Create a WordPress user with Auth0 data. | ||
| * | ||
| * @param object $userinfo - User profile data from Auth0. | ||
| * @param null|boolean $role - Set the sole as administrator - @deprecated - 3.8.0. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$admin_roleand$ignore_unverified_emailparameters in theWP_Auth0_LoginManagerconstruct methodend_session()method in theWP_Auth0_LoginManagerclass$roleparameter in thecreate_usermethod in theWP_Auth0_Usersclass$access_token,$role, and$skip_email_verifiedparameters in thecreatemethod of theWP_Auth0_UsersRepoclassNo functional changes 👍