Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp_auth0_get_option function to get option values #665

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Apr 8, 2019

Changes

Add wp_auth0_get_option() function for getting option values. This will make it easier for plugins/themes that extend the plugin.

Testing

  • This change adds unit test coverage

@@ -571,53 +573,6 @@ public static function get_plugin_dir_url() {
$a0_plugin = new WP_Auth0();
$a0_plugin->init();

if ( ! function_exists( 'get_auth0userinfo' ) ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved as-is to pluggable.php below

pluggable.php Outdated
*
* @return mixed
*/
function wp_auth0_get_option( $key, $default = null ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only new function is here.

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Apr 8, 2019
@joshcanhelp joshcanhelp force-pushed the add-get-option-function branch from b0414a1 to bf59767 Compare April 8, 2019 20:07
@joshcanhelp joshcanhelp force-pushed the add-get-option-function branch from bf59767 to de18a86 Compare April 8, 2019 20:08
@joshcanhelp joshcanhelp merged commit 0826f15 into master Apr 8, 2019
@joshcanhelp joshcanhelp deleted the add-get-option-function branch April 8, 2019 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants