Change CDN URL field type #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jul 30, 2019
| @@ -579,16 +579,6 @@ public function basic_validation( $old_options, $input ) { | |||
| $input['auth0_implicit_workflow'] = ( isset( $input['auth0_implicit_workflow'] ) ? $input['auth0_implicit_workflow'] : 0 ); | |||
| $input['force_https_callback'] = ( isset( $input['force_https_callback'] ) ? $input['force_https_callback'] : 0 ); | |||
|
|
|||
| $input['custom_cdn_url'] = empty( $input['custom_cdn_url'] ) ? 0 : 1; | |||
There was a problem hiding this comment.
Moved to lib/admin/WP_Auth0_Admin_Appearance.php
joshcanhelp
commented
Jul 30, 2019
| @@ -27,7 +27,7 @@ class TestOptionLockCdn extends WP_Auth0_Test_Case { | |||
| */ | |||
| public static function setUpBeforeClass() { | |||
| parent::setUpBeforeClass(); | |||
| self::$admin = new WP_Auth0_Admin_Advanced( self::$opts, new WP_Auth0_Routes( self::$opts ) ); | |||
| self::$admin = new WP_Auth0_Admin_Appearance( self::$opts, new WP_Auth0_Routes( self::$opts ) ); | |||
There was a problem hiding this comment.
Was testing the wrong class (setting methods were moved and deprecated).
damieng
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed an issue where the CDN URL is validated while being hidden, causing the settings page to fail while saving silently.
References
Internal support request.
Testing
Checklist