Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check state in specific global based on callback type #708

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Check state in specific global based on callback type #708

merged 2 commits into from
Aug 2, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Aug 1, 2019 •
edited
Loading

Changes

Fix state checking to look in the correct global ($_GET for auth code, $_POST for implicit) instead of query var or $_REQUEST.

References

Reverts #707

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 3.11.1 milestone Aug 1, 2019
@joshcanhelp joshcanhelp requested a review from damieng August 1, 2019 19:06
@joshcanhelp joshcanhelp marked this pull request as ready for review August 1, 2019 19:07
@joshcanhelp joshcanhelp requested review from a team and removed request for damieng August 1, 2019 20:00
@joshcanhelp joshcanhelp merged commit 41bcbcd into wordpress-org-plugin Aug 2, 2019
@joshcanhelp joshcanhelp deleted the fix-state-handling-to-specific-global branch August 2, 2019 15:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @luisrudge