Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve merge claims behavior #1232

Closed
pamapa opened this issue Nov 2, 2023 · 1 comment · Fixed by #1233
Closed

improve merge claims behavior #1232

pamapa opened this issue Nov 2, 2023 · 1 comment · Fixed by #1233
Assignees
@pamapa
Labels
breaking change
Milestone
3.0.0-beta.0

Comments

@pamapa
Copy link
Member

pamapa commented Nov 2, 2023 •
edited
Loading

  • In order to allow "refresh userinfo data on demand" refresh userinfo data on demand #877 merging claims must be adapted in way way that we can do it multiple times.
  • Changing the type of string to array by default (to preserve the previous different value) seems not a good idea. In case this is needed by some authz servers, we could add a special settings to have this behavior back (see #881#issuecomment-1425834324). mergeClaimsStrategy?: "replace" | "merge"]
  • drop misleading mergeClaims setting, we always merge ...
@pamapa pamapa added this to the 3.0.0 milestone Nov 2, 2023
@pamapa
Copy link
Member Author

pamapa commented Nov 2, 2023

@Badisi I will take the code from @marcoreni without the legacy fallback as a starting point for v3. See https://github.com/authts/oidc-client-ts/pull/881/files#diff-f13fa4d03ace5bba3b296851ab7dde13eafcc8e3643928cf369dd465af004d29R94

@pamapa pamapa self-assigned this Nov 2, 2023
@pamapa pamapa changed the title introduces new merge behavior for claims introduce new merge behavior for claims Nov 2, 2023
@pamapa pamapa changed the title introduce new merge behavior for claims improve merge claims behavior Nov 2, 2023
pamapa added a commit that referenced this issue Nov 2, 2023
@pamapa
feat: #1232 improve merge claims behavior
7dcfc2d
@pamapa pamapa mentioned this issue Nov 2, 2023
Merged
2 tasks
pamapa added a commit that referenced this issue Nov 2, 2023
@pamapa
feat: #1232 improve merge claims behavior
e4b9a37
pamapa added a commit that referenced this issue Nov 2, 2023
@pamapa
feat: #1232 improve merge claims behavior
e5b1e7b
pamapa added a commit that referenced this issue Nov 2, 2023
@pamapa
feat: #1232 improve merge claims behavior
e253265
pamapa added a commit that referenced this issue Nov 2, 2023
@pamapa
feat: #1232 improve merge claims behavior
68c1574
dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this issue Apr 3, 2024
@pamapa
feat: authts#1232 improve merge claims behavior
4884fc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pamapa pamapa

Labels
breaking change
Projects
None yet
Milestone
3.0.0-beta.0
Development

Successfully merging a pull request may close this issue.

improve merge claims behavior authts/oidc-client-ts
1 participant
@pamapa