Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom URL state values #1212

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

jafaircl
Copy link
Contributor

Closes/fixes #293

@pamapa @Badisi

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f64cfb3) 77.92% compared to head (047fb97) 78.09%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   77.92%   78.09%   +0.16%     
==========================================
  Files          45       45              
  Lines        1726     1739      +13     
  Branches      346      349       +3     
==========================================
+ Hits         1345     1358      +13     
  Misses        342      342              
  Partials       39       39              
Flag Coverage Δ
unittests 78.09% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OidcClient.ts 92.62% <ø> (ø)
src/ResponseValidator.ts 88.34% <100.00%> (+0.11%) ⬆️
src/SigninRequest.ts 100.00% <100.00%> (ø)
src/SigninResponse.ts 100.00% <100.00%> (ø)
src/SigninState.ts 100.00% <ø> (ø)
src/State.ts 85.29% <100.00%> (+0.44%) ⬆️
src/User.ts 80.76% <100.00%> (+0.76%) ⬆️
src/UserManager.ts 57.87% <ø> (ø)
src/errors/ErrorResponse.ts 92.85% <100.00%> (+0.54%) ⬆️
src/utils/UrlUtils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa
Copy link
Member

pamapa commented Oct 19, 2023

@Badisi i let you finish this review, you can tell me when i shall merge this...

@pamapa pamapa added this to the 2.3.1 milestone Oct 27, 2023
@pamapa pamapa merged commit e78ff98 into authts:main Oct 27, 2023
4 checks passed
dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this pull request Apr 3, 2024
* add support for custom url state values

---------

Co-authored-by: Jonathan Faircloth <jonathan.faircloth@wcgclinical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing state on Login Redirect
3 participants