Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extraTokenParams to UserManager.signinSilent #1258

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

MathiasRossen
Copy link

@MathiasRossen MathiasRossen commented Nov 21, 2023

Closes/fixes #1257

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

src/UserManager.ts Outdated Show resolved Hide resolved
src/UserManager.ts Outdated Show resolved Hide resolved
@pamapa
Copy link
Member

pamapa commented Nov 21, 2023

Thanks for taking care of this.
Also see npm run lint is failing in CI

@pamapa pamapa added this to the 3.0.0 milestone Nov 21, 2023
@MathiasRossen
Copy link
Author

Thank you, I will make some changes to resolve the issues

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d4395a) 78.43% compared to head (35faeef) 78.43%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          45       45           
  Lines        1730     1730           
  Branches      343      343           
=======================================
  Hits         1357     1357           
  Misses        336      336           
  Partials       37       37           
Flag Coverage Δ
unittests 78.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa merged commit 8dc1495 into authts:main Nov 24, 2023
4 checks passed
@pamapa
Copy link
Member

pamapa commented Nov 24, 2023

thanks for contributing

@MathiasRossen
Copy link
Author

Cheers! I am glad it was possible and thanks for your fast response 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extraTokenParams in UserManager.signinSilent()
3 participants