Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly throw an error when crypto.subtle is undefined #1300

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Dec 13, 2023

Closes/fixes #1299

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9380b18) 78.42% compared to head (287a433) 78.33%.

Files Patch % Lines
src/utils/CryptoUtils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   78.42%   78.33%   -0.10%     
==========================================
  Files          45       45              
  Lines        1729     1731       +2     
  Branches      343      344       +1     
==========================================
  Hits         1356     1356              
- Misses        336      338       +2     
  Partials       37       37              
Flag Coverage Δ
unittests 78.33% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa
Copy link
Member Author

pamapa commented Dec 13, 2023

@43081j Please review this small changes. The idea is to avoid people complaining its undefined when they are using not secure contexts...

@pamapa pamapa added this to the 3.0.0-rc.0 milestone Dec 13, 2023
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, good catch!

@pamapa pamapa merged commit 7ba6b72 into main Dec 14, 2023
2 of 4 checks passed
@pamapa pamapa deleted the fix-1299 branch December 14, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid crypto.subtle is undefined
2 participants