Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signoutRedirect not working #1383

Closed
wants to merge 1 commit into from
Closed

signoutRedirect not working #1383

wants to merge 1 commit into from

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Feb 5, 2024

Closes/fixes #1379

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa
Copy link
Member Author

pamapa commented Feb 5, 2024

@PSanetra and @ch-lepp Something like this? I have not yet adapted the unit-tests...

@PSanetra
Copy link
Contributor

PSanetra commented Feb 5, 2024

@pamapa sorry, I don't have much time today to look into this. I can look into this tomorrow. But please consider adding a setting to UserManager to configure if a signout redirect is expected or not. (Like mentioned in #1379)

@pamapa
Copy link
Member Author

pamapa commented Feb 7, 2024

This does not solve this case:

  • the callback might not be called by the IDP (e.g. no valid session), the client stays in a non fixable state (the user is still stored locally and will not be removed due to the not coming callback)

@pamapa pamapa marked this pull request as draft February 7, 2024 09:00
@pamapa pamapa closed this Feb 7, 2024
@pamapa pamapa deleted the fix-1379 branch February 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserManager signoutRedirect not working
2 participants