Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve id_token and profile even if no openid is in scope of refresh request #763

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Nov 14, 2022

Closes/fixes #754

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 77.73% // Head: 77.65% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (edfef08) compared to base (2e49894).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   77.73%   77.65%   -0.08%     
==========================================
  Files          44       44              
  Lines        1648     1665      +17     
  Branches      316      319       +3     
==========================================
+ Hits         1281     1293      +12     
- Misses        336      339       +3     
- Partials       31       33       +2     
Flag Coverage Δ
unittests 77.65% <83.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ResponseValidator.ts 90.24% <83.33%> (ø)
src/UserManagerSettings.ts 98.30% <0.00%> (+0.05%) ⬆️
src/UserManager.ts 57.87% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/ResponseValidator.ts Outdated Show resolved Hide resolved
@pamapa pamapa force-pushed the fix-754 branch 2 times, most recently from 52fdec9 to 47b4fa1 Compare November 15, 2022 15:36
@pamapa pamapa mentioned this pull request Nov 18, 2022
2 tasks
src/ResponseValidator.ts Show resolved Hide resolved
@pamapa
Copy link
Member Author

pamapa commented Nov 21, 2022

@longsleep would be cool if you can have a look at it again, i have fixed what you requested...

@longsleep longsleep self-requested a review November 21, 2022 15:21
Copy link
Contributor

@longsleep longsleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@pamapa pamapa merged commit c52ba8b into main Nov 22, 2022
@pamapa pamapa deleted the fix-754 branch November 22, 2022 08:21
@pamapa pamapa added this to the 2.2.0 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signinSilent using refresh token clears profile info
2 participants