RequestID utilities #176
Merged
RequestID utilities #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds function to inject a request ID into the gRPC headers when making a request to SpiceDB. This will be used to enable the '--request-id' flag in the 'zed' CLI.
ecordell
approved these changes
Mar 20, 2024
| // through SpiceDB for the lifetime of the request. This can be used to correlate logs | ||
| // and traces with a specific request. | ||
| // | ||
| // TODO(alecmerdler): This is duplicated in SpiceDB source; we should be importing it from here. |
There was a problem hiding this comment.
nit: this seems like the wrong place for this TODO since it needs to change in a different project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to inject a request ID into the gRPC headers when making a request to SpiceDB. This will be used to enable the
--request-idflag in thezedCLI.