Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit dependencies to package.json #16

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

lewisl9029
Copy link
Contributor

Hi! I tried to use this in a project that uses yarn PnP, and it threw this error:

https://classic.yarnpkg.com/lang/en/docs/pnp/troubleshooting/#toc-is-trying-to-require-without-it-being-listed-in-its-dependencies

This error simply means that the specified package is requiring something without explicitly declaring it in its dependencies. Since this behavior is unsafe and relies on the hoisting being done a certain way, Plug’n’Play doesn’t allow it.

This PR simply adds those implicit dependencies to the top level package.json. Seems like a harmless change, but happy to iterate if you have any concerns.

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lewisl9029
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@samkim samkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr merged commit 3b63992 into authzed:main Dec 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2021
@lewisl9029 lewisl9029 deleted the add-implicit-dependencies branch December 28, 2021 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants