Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use script instead of abandoned lib #164

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

I went and checked the npm registry and the version wasn't v1.0.1. The version getting step didn't work as desired, so the version setting step was a read-only step rather than something that set the version. This fixes that.

The version getting action is 3 years out of date at this point, so we're using a script instead of it.

Changes

  • Use the script approach that works in other libs

Testing

Release and see that the version appears on npm.

@tstirrat15 tstirrat15 requested a review from a team as a code owner October 3, 2024 17:24
@tstirrat15 tstirrat15 merged commit 4ad599b into main Oct 3, 2024
7 checks passed
@tstirrat15 tstirrat15 deleted the fix-version-setting-on-release branch October 3, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants