Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a default nsswitch.conf file #60

Merged
merged 1 commit into from
Sep 2, 2021
Merged

add a default nsswitch.conf file #60

merged 1 commit into from
Sep 2, 2021

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Sep 2, 2021 •
edited
Loading

The go networking stack will hit dns first unless you configure it
otherwise

Without this, grpc_health_probe can fail to hit localhost due to slow
external dns

Docs:

@github-actions github-actions bot added area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Sep 2, 2021
@ecordell
add a default nsswitch.conf file
a3c3b7d 
the go networking stack will hit dns first unless you configure it
otherwise

without this, grpc_health_probe can fail to hit localhost due to slow
external dns

Signed-off-by: Evan Cordell <cordell.evan@gmail.com>
josephschorr
josephschorr approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 640ede2 into main Sep 2, 2021
@ecordell ecordell deleted the nsswitch branch September 2, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees
No one assigned
Labels
area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecordell @josephschorr