Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ExternallyOwned for instance dependencies #120

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

alistairjevans
Copy link
Member

Fixes #15

@alistairjevans alistairjevans requested a review from tillig August 11, 2024 09:33
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (dc03f10) to head (ecec468).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
+ Coverage    90.69%   90.72%   +0.02%     
===========================================
  Files           15       15              
  Lines          344      345       +1     
  Branches        69       69              
===========================================
+ Hits           312      313       +1     
  Misses          20       20              
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦿

@tillig tillig merged commit eb20702 into develop Aug 11, 2024
4 checks passed
@tillig tillig deleted the external-dependency-switch branch August 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with disposable singletons
2 participants