Issue #880: Removed skipped test, added test for new decorator syntax.

autofac · Sep 25, 2020 · 4f3be18 · 4f3be18
1 parent 46e8503
commit 4f3be18
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 24 deletions.
diff --git a/test/Autofac.Specification.Test/Features/DecoratorTests.cs b/test/Autofac.Specification.Test/Features/DecoratorTests.cs
@@ -984,6 +984,23 @@ public void DecoratorsApplyToKeyedServices()
             Assert.IsType<ImplementorA>(instance.Decorated);
         }
 
+        [Fact]
+        public void DecoratorsApplyToNamedAndDefaultServices()
+        {
+            // Issue #529, #880: Old decorator syntax failed if a component
+            // being decorated was registered with both As<T>() and Named<T>().
+            var builder = new ContainerBuilder();
+
+            builder.RegisterType<ImplementorA>().As<IDecoratedService>().Named<IDecoratedService>("service");
+            builder.RegisterDecorator<DecoratorA, IDecoratedService>();
+            var container = builder.Build();
+
+            var instance = container.Resolve<IDecoratedService>();
+
+            Assert.IsType<DecoratorA>(instance);
+            Assert.IsType<ImplementorA>(instance.Decorated);
+        }
+
         [Theory]
         [InlineData(typeof(IDecoratedService), typeof(ISomeOtherService))]
         [InlineData(typeof(ISomeOtherService), typeof(IDecoratedService))]

diff --git a/...utofac.Test/Features/LightweightAdapters/LightweightAdapterRegistrationExtensionsTests.cs b/...utofac.Test/Features/LightweightAdapters/LightweightAdapterRegistrationExtensionsTests.cs
@@ -88,30 +88,6 @@ public void AdaptedMetadataIsPassed()
             }
         }
 
-        public class DecoratingServiceThatHasDefaultImplementation
-        {
-            private readonly IContainer _container;
-
-            public DecoratingServiceThatHasDefaultImplementation()
-            {
-                const string from = "from";
-                var builder = new ContainerBuilder();
-
-                builder.RegisterType<Implementer1>().As<IService>().Named<IService>(from);
-                builder.RegisterDecorator<IService>(s => new Decorator(s), from);
-
-                _container = builder.Build();
-            }
-
-            [Fact(Skip = "Issue #529 => #880")]
-            public void InstanceWithDefaultImplementationIsDecorated()
-            {
-                var decorator = _container.Resolve<IService>();
-                Assert.IsType<Decorator>(decorator);
-                Assert.IsType<Implementer1>(((Decorator)decorator).Decorated);
-            }
-        }
-
         public interface IService
         {
         }