You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While putting together a blog post on the v6 release, it occurred to me that we do not have a way for Diagnostic Event handlers to know whether the Trace they are getting is for a successful resolve operation, or a failing one.
I can imagine users might want to save failing resolves to whatever output, to reduce the amount of trace they have to wade through when diagnosing errors in a bigger system.
I think we should add a boolean OperationSucceeded flag to OperationTraceCompletedArgs, which just indicates whether the operation failed or not. We already have this information available in the Diagnostic Tracer, so should be a trivial addition.
I'll raise a PR for the change, but thought I'd raise the issue first for discussion.
The text was updated successfully, but these errors were encountered:
While putting together a blog post on the v6 release, it occurred to me that we do not have a way for Diagnostic Event handlers to know whether the Trace they are getting is for a successful resolve operation, or a failing one.
I can imagine users might want to save failing resolves to whatever output, to reduce the amount of trace they have to wade through when diagnosing errors in a bigger system.
I think we should add a boolean
OperationSucceeded
flag toOperationTraceCompletedArgs
, which just indicates whether the operation failed or not. We already have this information available in the Diagnostic Tracer, so should be a trivial addition.I'll raise a PR for the change, but thought I'd raise the issue first for discussion.
The text was updated successfully, but these errors were encountered: