Skip to content

Commit

Permalink
fix embedding model name argument
Browse files Browse the repository at this point in the history
  • Loading branch information
shreyash2106 committed Jul 31, 2024
1 parent 6972c1c commit f564c03
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/agrag/agrag.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def initialize_data_module(self):
def initialize_embeddings_module(self):
"""Initializes the Embedding module."""
self.embedding_module = EmbeddingModule(
model_name=self.args.hf_embedding_model,
model_name=self.args.embedding_model,
pooling_strategy=self.args.pooling_strategy,
normalize_embeddings=self.args.normalize_embeddings,
hf_model_params=self.args.hf_model_params,
Expand Down
6 changes: 3 additions & 3 deletions src/agrag/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,13 @@ def data_file_extns(self, value):
self.config["data"]["file_extns"] = value

@property
def hf_embedding_model(self):
def embedding_model(self):
return self.config.get("embedding", {}).get(
"embedding_model", self.embedding_defaults.get("DEFAULT_EMBEDDING_MODEL")
)

@hf_embedding_model.setter
def hf_embedding_model(self, value):
@embedding_model.setter
def embedding_model(self, value):
self.config["embedding"]["embedding_model"] = value

@property
Expand Down

0 comments on commit f564c03

Please sign in to comment.