Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config_file argument #46

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

cheungdaven
Copy link
Collaborator

The config_file argument is missing when using config files as input.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The config_file argument is missing when using config files as input.
Copy link
Collaborator

@shreyash2106 shreyash2106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 130 we have self.config = config_file or self._load_preset()

And then in line 131 we have self.args = Arguments(self.config)

In the Arguments class, we load the config file from the passed in configuration path which is either a preset or a config file path.

Thus this issue should not arise if the user uses a config. We can remove the lines

if config_file:
       self._load_config()
elif self.preset_quality:
       self._load_preset()

And also modify the docstring in the Arguments class

@cheungdaven
Copy link
Collaborator Author

_load_config

I encountered this issue when using config_file: TypeError: AutoGluonRAG._load_config() missing 1 required positional argument: 'config_file'

@shreyash2106
Copy link
Collaborator

_load_config

I encountered this issue when using config_file: TypeError: AutoGluonRAG._load_config() missing 1 required positional argument: 'config_file'

Yeah we will have to remove the lines

if config_file:
       self._load_config()
elif self.preset_quality:
       self._load_preset()

@cheungdaven
Copy link
Collaborator Author

_load_config

I encountered this issue when using config_file: TypeError: AutoGluonRAG._load_config() missing 1 required positional argument: 'config_file'

Yeah we will have to remove the lines

if config_file:
       self._load_config()
elif self.preset_quality:
       self._load_preset()

removed

Copy link
Collaborator

@shreyash2106 shreyash2106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cheungdaven cheungdaven merged commit 8ae0b77 into autogluon:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants