test that illustrates failure scenario for issue #54 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to later walk and clean up where needed
…container when found
heckj
added a commit
that referenced
this pull request
Jul 30, 2023
* test that illustrates failure scenario for issue #54 * establishing a tree of AutomergeEncoderImpl during encoding to be able to later walk and clean up where needed * tracking keys written, highest index written, and objectIds for each container when found * removing extraneous elements from tree, test to verify tree integrity * verifying ObjectId found for each relevant container * enables post-encoding cleanup using details from captured encode-tree
heckj
added a commit
that referenced
this pull request
Jul 30, 2023
heckj
added a commit
that referenced
this pull request
Jul 30, 2023
heckj
added a commit
that referenced
this pull request
Jul 30, 2023
heckj
added a commit
that referenced
this pull request
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54
Captures the encoding tree as the encoder works between local code and synthesized or provided Codable implementations for types, capturing the details of what containers were written - max index positions and keys written/updated. Post-encode walks that tree and removes any extra values - which allows for keys to be removed from maps, and arrays to shrink to encoded positions.