Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --listen-address to --explorer-address #44

Closed
keturiosakys opened this issue Jun 22, 2023 · 5 comments
Closed

Rename --listen-address to --explorer-address #44

keturiosakys opened this issue Jun 22, 2023 · 5 comments

Comments

@keturiosakys
Copy link
Member

The flag --listen-address is ambiguous as to what exactly will be listening on
that port. We should consider renaming it to --explorer-listen-address or
--explorer-port.

@hatchan
Copy link
Contributor

hatchan commented Jun 22, 2023

I don't agree with this, since explorer is only one of the things that we are hosting on the port. I also think that --listen-address or -l is pretty common.

@brettimus
Copy link
Contributor

so this is worth noting because i'd also proposed the same change, independently of lau :)

--listen-address might be common in certain worlds, but my opinion is that a user would more intuitively understand that the --explorer-address is where the explorer would be hosted

@brettimus
Copy link
Contributor

brettimus commented Jun 22, 2023

we could... alias (i.e., "why not both")? or is that just confusing?

@keturiosakys
Copy link
Member Author

Ah gotcha - maybe indeed we should have an alias then.

@hatchan
Copy link
Contributor

hatchan commented Jun 26, 2023

Closed by #50

@hatchan hatchan closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants