Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple quality of life improvements #50

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Multiple quality of life improvements #50

merged 6 commits into from
Jun 26, 2023

Conversation

hatchan
Copy link
Contributor

@hatchan hatchan commented Jun 26, 2023 •
edited
Loading

  • Extend argument documentation
  • Make reqwest client only available to the crate
  • Redirect users to explorer app when using / or /explore as their path

Resolves: #45, #51, #44

@hatchan hatchan requested a review from mellowagain June 26, 2023 13:36
hatchan
hatchan commented Jun 26, 2023
View reviewed changes
src/bin/am/commands/start.rs Outdated Show resolved Hide resolved
@hatchan hatchan requested review from keturiosakys and removed request for mellowagain June 26, 2023 14:03
mellowagain
mellowagain approved these changes Jun 26, 2023
View reviewed changes
src/bin/am/commands/start.rs Outdated Show resolved Hide resolved
src/bin/am/commands/start.rs Show resolved Hide resolved
@hatchan hatchan requested a review from mellowagain June 26, 2023 14:07
@hatchan
Use verbatim_doc_comment on metrics_endpoints
162d507 
Use temporary redirect when visiting the root address
@hatchan hatchan merged commit 7279f21 into main Jun 26, 2023
@hatchan hatchan deleted the explain_pushgatway branch June 26, 2023 14:52
This was referenced Jun 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mies mies mies approved these changes

@keturiosakys keturiosakys keturiosakys approved these changes

@mellowagain mellowagain mellowagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more documentation on the push gateway in the CLI
4 participants
@hatchan @mies @keturiosakys @mellowagain