Fix multiarch docker image for arm64 users #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variant will be set by Docker/containerd. Until we support multiple arm variants we can use this simple notation.
hatchan
added a commit
that referenced
this pull request
Aug 24, 2023
* Fix multiarch docker image for arm64 users * Update changelog * Also publish 'latest' tag * Remove specific variant This variant will be set by Docker/containerd. Until we support multiple arm variants we can use this simple notation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker image shouldn't use a specific architecture as the base image, and
the platform should require a
/between the architecture and variant.NOTE: This does mean that this will probably not work correctly when we have multiple
ARM variants. Possibly we can use the
TARGETVARIANTfor theCOPYstatement.Checklist