Add markdown reference generator #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatchan
approved these changes
Jun 21, 2023
src/bin/am/commands.rs
Outdated
| SubCommands::System(args) => system::handle_command(args).await, | ||
| Some(SubCommands::Start(args)) => start::handle_command(args).await, | ||
| Some(SubCommands::System(args)) => system::handle_command(args).await, | ||
| None => return Ok(()), |
There was a problem hiding this comment.
Is this possible to occur? Shouldn't we print the usage in this case?
mellowagain
approved these changes
Jun 21, 2023
src/bin/am/commands.rs
Outdated
| @@ -8,7 +8,9 @@ pub mod system; | |||
| #[command(author, version, about, long_about = None)] | |||
| pub struct Application { | |||
| #[command(subcommand)] | |||
| pub command: SubCommands, | |||
| pub command: Option<SubCommands>, | |||
| #[clap(long, hide = true)] | |||
There was a problem hiding this comment.
maybe we can make this required_unless_present = "command" or the other way around (command is required unless markdown_help is present)
https://docs.rs/clap/latest/clap/struct.Arg.html#method.required_unless_present
There was a problem hiding this comment.
I guess we can also make it a sub-command 🤔
There was a problem hiding this comment.
agree, making it a subcommand makes the most sense
mellowagain
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a markdown reference generator to the CLI.