-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #525
Improve CI #525
Conversation
Codecov Report
@@ Coverage Diff @@
## development #525 +/- ##
============================================
Coverage 83.75% 83.75%
============================================
Files 61 61
Lines 5362 5362
============================================
Hits 4491 4491
Misses 871 871 Continue to review full report at Codecov.
|
The output of the newly added script is now visible in the succeeding unit tests: https://travis-ci.org/automl/SMAC3/jobs/571394398 |
How strict is PEP8 here? I think we agreed at some point that we allow for some more characters per line. |
Good that you're asking. I already catered for that and this change allows for 120 lines: https://github.com/automl/SMAC3/pull/525/files#diff-8572f4480db0a9c3d9b26e97c77de7d1R129 |
Okay, I approved it. Nevertheless, I hope I won't be too annoyed by it in the future ;-) |
Me too, but for OpenML, this works really well. |
Improve CI by requiring code changes to adhere to PEP8. I see this as a first stop towards uniformly formatted code.