Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #525

Merged
merged 7 commits into from
Aug 22, 2019
Merged

Improve CI #525

merged 7 commits into from
Aug 22, 2019

Conversation

mfeurer
Copy link
Contributor

@mfeurer mfeurer commented Aug 13, 2019

Improve CI by requiring code changes to adhere to PEP8. I see this as a first stop towards uniformly formatted code.

@mfeurer mfeurer marked this pull request as ready for review August 13, 2019 08:38
@mfeurer mfeurer closed this Aug 13, 2019
@mfeurer mfeurer reopened this Aug 13, 2019
@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #525 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #525   +/-   ##
============================================
  Coverage        83.75%   83.75%           
============================================
  Files               61       61           
  Lines             5362     5362           
============================================
  Hits              4491     4491           
  Misses             871      871

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef02f3...14676ec. Read the comment docs.

@mfeurer
Copy link
Contributor Author

mfeurer commented Aug 22, 2019

The output of the newly added script is now visible in the succeeding unit tests: https://travis-ci.org/automl/SMAC3/jobs/571394398

@mlindauer
Copy link
Contributor

How strict is PEP8 here? I think we agreed at some point that we allow for some more characters per line.

@mfeurer
Copy link
Contributor Author

mfeurer commented Aug 22, 2019

Good that you're asking. I already catered for that and this change allows for 120 lines: https://github.com/automl/SMAC3/pull/525/files#diff-8572f4480db0a9c3d9b26e97c77de7d1R129

@mfeurer mfeurer merged commit afca730 into development Aug 22, 2019
@mfeurer mfeurer deleted the improve_ci branch August 22, 2019 12:51
@mlindauer
Copy link
Contributor

Okay, I approved it. Nevertheless, I hope I won't be too annoyed by it in the future ;-)

@mfeurer
Copy link
Contributor Author

mfeurer commented Aug 22, 2019

I hope I won't be too annoyed by it in the future ;-)

Me too, but for OpenML, this works really well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants