Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve runhistory type checks #706

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Improve runhistory type checks #706

merged 3 commits into from
Nov 9, 2020

Conversation

mfeurer
Copy link
Contributor

@mfeurer mfeurer commented Nov 9, 2020 •
edited
Loading

This PR moves a check that entries in the runhistory can be serialized from the TAE for functions to the runhistory class. This has two advantages:

  1. All TAEs profit from this check
  2. A try/except around the current check prevented it from making SMAC fail and show the error message. Instead, SMAC would fail when serializing the runhistory at the end of the optimization.

@mfeurer mfeurer merged commit 97af094 into development Nov 9, 2020
@mfeurer mfeurer deleted the debug_runhistory_serialization_error branch November 9, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KEggensperger KEggensperger KEggensperger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfeurer @KEggensperger